Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a top/bottom functionality to zurb offcanvas with push,overlap and submenu #6601

Merged

Conversation

tomsah
Copy link
Contributor

@tomsah tomsah commented Jun 3, 2015

You can see the adding functionality in action on this demo page

http://tomsah.co.uk/offcanvas-demo/

Please let me know if any improvement is needed or more need to be done.

very best

@gakimball
Copy link
Contributor

This looks really nice! How does it work with the multi-level menu?

@rafibomb
Copy link
Member

This really cool! I'm going to pull this in. We can add the documentation.

The top and bottom menu's don't work with the multi-level feature. Is this something you can tackle?

@rafibomb rafibomb merged commit 402d7f1 into foundation:master Jun 20, 2015
@rafibomb
Copy link
Member

I added this to the docs - f567074

@tomsah
Copy link
Contributor Author

tomsah commented Sep 21, 2015

Hello Zurb Team,

I have send the first draft for the top and bottom off canvas and i am
really happy to see it live.
I can see you guys did improved it a lot too, good work!!!!

I am sorry I could not help more to fix sub menu and documentation
but I was working on a big Drupal site using foundation theme and it took
all of my time. (I will send you the link of the site as soon as it is
finish.)

i was wondering if there is anyway to get a recommendation from you guys on
linked in
https://uk.linkedin.com/pub/thomas-salah/54/17a/611

or any sort of justification that i participate to Zurb project.

This will be great for my curriculum as a junior front end to carry on.

Many thanks for taking my code and make it better.
I am looking forward to help you more in the very near future.

Thomas

On 22 June 2015 at 18:59, Rafi notifications@github.com wrote:

I added this to the docs - f567074
f567074


Reply to this email directly or view it on GitHub
#6601 (comment).

@rafibomb
Copy link
Member

@tomsah Thanks for this great PR! We want you to be part of the Foundation 6 private release team. Email rafi at zurb .com to be part of it!

@jacobalvarez jacobalvarez mentioned this pull request Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants